Fix random mod generating off-screen sliders #18596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to get this in since the code is non-offensive and it probably can't break things more than they already are. |
peppy
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #18559 (comment)
The issue is caused by long horizontal sliders spanning the whole width of the playfield. Rotating them 90 degrees causes them to go off-screen. This fix limits those large sliders to either 0 or 180 degrees rotation (whichever is closest to the original angle to which the algorithm wishes to rotate the slider).
Original map:
Old algorithm with seed 0:
This fix with seed 0:
